Line2: increase test coverage by scpeters · Pull Request #807 · gazebosim/gz-math

scpeters · 2026-08-21T00:03:08Z

🦟 Bug fix

Improve test coverage of Line2 class

Summary

This increases test coverage based on suggestions from Gemini. After observing some windows C4244 compiler warnings, I fixed them in 2a719e4:

Fix warnings in Set(double, double, double, double) by wrapping with static_cast<T>
Fix warning in Length() by using the simpler implementation from Line3.hh wrapped with static_cast<T>:

gz-math/include/gz/math/Line3.hh

Lines 135 to 138 in 396f5a5

    
           public: T Length() const 
        
           { 
        
             return this->pts[0].Distance(this->pts[1]); 
        
           }

Summary of test coverage improvements

Set with Vector2 parameters: Verified setting start/end points using Vector2 instances.
CrossProduct: Added explicit tests for both Line2 and Vector2 cross products. Expect CrossProduct of parallel lines is 0.
OnSegment and Within: Tested points on segment, collinear points outside bounds, non-collinear points within bounding box, and endpoints.
Intersect Branch Coverage:
- Parallel collinear non-overlapping line segments.
- Collinear lines where only the second endpoint lies on the segment.
- Line extensions that intersect outside X or Y bounding ranges.
- Intersect overload taking no output point.
Operators: Expanded operator== and operator!= self-comparison checks.
Template Types: Added test cases for Line2i (int) and Line2f (float).

Backport Policy

Checklist

Assisted-by: Gemini 3.6 Flash

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.

Backports: If this is a backport, please use Rebase and Merge instead.

1. Set with Vector2 parameters: Verified setting start/end points using Vector2 instances. 2. CrossProduct: Added explicit tests for both Line2 and Vector2 cross products. Expect CrossProduct of parallel lines is 0. 3. OnSegment and Within: Tested points on segment, collinear points outside bounds, non-collinear points within bounding box, and endpoints. 4. Intersect Branch Coverage: • Parallel collinear non-overlapping line segments. • Collinear lines where only the second endpoint lies on the segment. • Line extensions that intersect outside X or Y bounding ranges. • Intersect overload taking no output point. 5. Operators: Expanded operator== and operator!= self-comparison checks. 6. Template Types: Added test cases for Line2i (int) and Line2f (float). Assisted-by: Gemini 3.6 Flash Signed-off-by: Steve Peters <scpeters@intrinsic.ai>

Signed-off-by: Steve Peters <scpeters@intrinsic.ai>

* Set: use static_cast<T> * Length: use simpler approach from Line3::Length along with static_cast<T> Signed-off-by: Steve Peters <scpeters@intrinsic.ai>

ahcorde · 2026-08-25T08:41:52Z

https://github.com/Mergifyio backport gz-math9 gz-math8 gz-math7 ign-math6

mergify · 2026-08-25T08:42:22Z

backport gz-math9 gz-math8 gz-math7 ign-math6

✅ Backports have been created

Details

#826 Line2: increase test coverage (backport #807) has been created for branch gz-math9
#827 Line2: increase test coverage (backport #807) has been created for branch gz-math8 but encountered conflicts

Cherry-pick of 268039c has failed:

On branch mergify/bp/gz-math8/pr-807
Your branch is up to date with 'origin/gz-math8'.

You are currently cherry-picking commit 268039c.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   include/gz/math/Line2.hh
	modified:   src/Line2_TEST.cc

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   src/python_pybind11/test/Line2_TEST.py

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

#828 Line2: increase test coverage (backport #807) has been created for branch gz-math7 but encountered conflicts

Cherry-pick of 268039c has failed:

On branch mergify/bp/gz-math7/pr-807
Your branch is up to date with 'origin/gz-math7'.

You are currently cherry-picking commit 268039c.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   include/gz/math/Line2.hh
	modified:   src/Line2_TEST.cc

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   src/python_pybind11/test/Line2_TEST.py

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

#829 Line2: increase test coverage (backport #807) has been created for branch ign-math6 but encountered conflicts

Cherry-pick of 268039c has failed:

On branch mergify/bp/ign-math6/pr-807
Your branch is up to date with 'origin/ign-math6'.

You are currently cherry-picking commit 268039c.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   src/Line2_TEST.cc

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   include/gz/math/Line2.hh
	both modified:   src/python_pybind11/test/Line2_TEST.py

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

1. Set with Vector2 parameters: Verified setting start/end points using Vector2 instances. 2. CrossProduct: Added explicit tests for both Line2 and Vector2 cross products. Expect CrossProduct of parallel lines is 0. 3. OnSegment and Within: Tested points on segment, collinear points outside bounds, non-collinear points within bounding box, and endpoints. 4. Intersect Branch Coverage: • Parallel collinear non-overlapping line segments. • Collinear lines where only the second endpoint lies on the segment. • Line extensions that intersect outside X or Y bounding ranges. • Intersect overload taking no output point. 5. Operators: Expanded operator== and operator!= self-comparison checks. 6. Template Types: Added test cases for Line2i (int) and Line2f (float). Assisted-by: Gemini 3.6 Flash Fix type conversion warnings * Set: use static_cast<T> * Length: use simpler approach from Line3::Length along with static_cast<T> (cherry picked from commit 268039c) Signed-off-by: Steve Peters <scpeters@intrinsic.ai> Co-authored-by: Steve Peters <scpeters@intrinsic.ai>

(cherry picked from commit 268039c) Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com> Co-authored-by: Steve Peters <scpeters@intrinsic.ai> Co-authored-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>

Assisted-by: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Carlos Agüero <caguero@honurobotics.com>

azeey added this to Core development Aug 21, 2026

github-actions Bot added the 🎡 rotary label Aug 21, 2026

github-project-automation Bot moved this to Inbox in Core development Aug 21, 2026

reduce line length

70aac2d

Signed-off-by: Steve Peters <scpeters@intrinsic.ai>

scpeters mentioned this pull request Aug 21, 2026

Line2: use T instead of double in APIs #809

Merged

20 tasks

Fix type conversion warnings

2a719e4

* Set: use static_cast<T> * Length: use simpler approach from Line3::Length along with static_cast<T> Signed-off-by: Steve Peters <scpeters@intrinsic.ai>

scpeters force-pushed the scpeters/line2_more_test_coverage branch from 84266d7 to 2a719e4 Compare August 21, 2026 01:55

scpeters marked this pull request as ready for review August 21, 2026 03:08

scpeters requested a review from adityapande-1995 as a code owner August 21, 2026 03:08

scpeters changed the title ~~Increase test coverage of Line2 class~~ Line2: increase test coverage Aug 21, 2026

This was referenced Aug 21, 2026

Line3: increase test coverage #813

Merged

Filter: increase test coverage #816

Open

mergify Bot mentioned this pull request Aug 22, 2026

Line3: increase test coverage (backport #813) #821

Open

19 tasks

ahcorde approved these changes Aug 24, 2026

View reviewed changes

github-project-automation Bot moved this from Inbox to In review in Core development Aug 24, 2026

Merge branch 'main' into scpeters/line2_more_test_coverage

8470c97

scpeters enabled auto-merge (squash) August 24, 2026 21:40

scpeters merged commit 268039c into main Aug 24, 2026
14 checks passed

scpeters deleted the scpeters/line2_more_test_coverage branch August 24, 2026 21:44

github-project-automation Bot moved this from In review to Done in Core development Aug 24, 2026

This was referenced Aug 25, 2026

Line2: increase test coverage (backport #807) #826

Merged

Line2: increase test coverage (backport #807) #827

Merged

Line2: increase test coverage (backport #807) #828

Merged

Line2: increase test coverage (backport #807) #829

Merged

This was referenced Aug 25, 2026

Line2: use T instead of double in APIs (backport #809) #830

Merged

Line2: use T instead of double in APIs (backport #809) #831

Merged

Line2: use T instead of double in APIs (backport #809) #832

Merged

caguero added a commit that referenced this pull request Aug 25, 2026

Line2: increase test coverage (backport #807)

bfae060

Assisted-by: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Carlos Agüero <caguero@honurobotics.com>

caguero added a commit that referenced this pull request Aug 25, 2026

Line2: increase test coverage (backport #807)

28a6008

Assisted-by: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Carlos Agüero <caguero@honurobotics.com>

caguero added a commit that referenced this pull request Aug 25, 2026

Line2: increase test coverage (backport #807)

85a1d7d

Assisted-by: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Carlos Agüero <caguero@honurobotics.com>

This was referenced Aug 26, 2026

Line3: increase test coverage (backport #813) #835

Open

Line3: increase test coverage (backport #813) #836

Open

Navigation Menu

Uh oh!

Line2: increase test coverage - #807

Line2: increase test coverage#807
scpeters merged 4 commits into
mainfrom
scpeters/line2_more_test_coverage

scpeters commented Aug 21, 2026 •

edited

Loading

Uh oh!

Uh oh!

ahcorde commented Aug 25, 2026

Uh oh!

mergify Bot commented Aug 25, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	public: T Length() const
	{
	return this->pts[0].Distance(this->pts[1]);
	}

Uh oh!

Conversation

scpeters commented Aug 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦟 Bug fix

Summary

Summary of test coverage improvements

Backport Policy

Checklist

Uh oh!

Uh oh!

ahcorde commented Aug 25, 2026

Uh oh!

mergify Bot commented Aug 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

scpeters commented Aug 21, 2026 •

edited

Loading

mergify Bot commented Aug 25, 2026 •

edited

Loading